Add sinceVersion to bundle schema #4276
Open
+5,727
−1,027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
Collaborator
|
Commit: 2d1f03d
28 interesting tests: 17 RECOVERED, 6 KNOWN, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Jan 14, 2026
| ) | ||
|
|
||
| // Version when bundle/schema/jsonschema.json was added to the repo. | ||
| var embeddedSchemaVersion = [3]int{0, 229, 0} |
Contributor
Author
There was a problem hiding this comment.
There's a slight inaccuracy, because of this the oldest version we have is 0.229.0. I think that's fine. We don't need to be super accurate here since that's a ancient version anyways.
shreyas-goenka
changed the title
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
sinceVersionfield to the bundle JSON schema output, indicating which CLI version each field was introduced in. This version information will be displayed in our documentation.The implementation:
annotations.ymlandannotations_openapi_overrides.yml).last_processed_cli_versionto process versions incrementallysinceVersionin the generated JSON schemaTest plan
make schemagenerates schema with version annotationsmake lintpassesNote: There's a off by one problem here where the version information will only be updated in the next release. That is if a feature is released in v1, the metadata will only show up in the JSON schema in v2. This is because the code relies on already done releases.